[Milkymist-devel] Fwd: Re: DOpE port to Milkymist

[Sébastien Bourdeauducq]

----------  Forwarded Message  ----------

Subject: Re: DOpE port to Milkymist
Date: Wednesday 26 August 2009
From: Norman Feske <norman.feske at genode-labs.com>
To: Sébastien Bourdeauducq <sebastien.bourdeauducq at lekernel.net>

Hi Sébastien,

I have now included your Milkymist port into the Genode-FX SVN. The
patch has a really good quality. I could compile the result without
any problems. I only had to fix two little problems:

* The second part of the 'grid.c' patch was not correct. There was
  a wrong & character for the non-NO_DOUBLE case. I noticed the
  problem when compiling dope-embedded for one of the other platforms.

* The double specification of baselib.a is not needed. I guess you
  specified it twice to enable the linker to resolve cross-object
  dependencies correctly (it is a usual problem that the order
  of libraries is important for resolving symbols but if libraries
  contain circular dependencies, dependencies cannot be resolved
  in one pass). However, this problem can be solved by using the
  --start-group --endgroup feature of the GNU linker. So I could
  get rid of your funny comment .-)

Thanks again for your cool contribution. Future patches are more than
welcome.

Cheers
Norman

-------------------------------------------------------